Skip to content

Finalize transfer decoding before callbacks - #336

Merged
Kludex merged 2 commits into
mainfrom
finalize-transfer-decoder-before-callback
Oct 11, 2026
Merged

Finalize transfer decoding before callbacks#336
Kludex merged 2 commits into
mainfrom
finalize-transfer-decoder-before-callback

Conversation

@Kludex

@Kludex Kludex commented Oct 11, 2026 •
edited by cubic-dev-ai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Finalize each Content-Transfer-Encoding decoder when its part ends.
  • Invoke field and file callbacks after decoding is complete.
  • Cover trailing buffered quoted-printable data.

Testing

  • uv run pytest
  • uv run ruff format --check --diff python_multipart multipart tests
  • uv run ruff check python_multipart multipart tests
  • uv run mypy python_multipart multipart tests

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

View guided diff

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T13:42:46.222637Z 79fb73a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codspeed

codspeed Bot commented Oct 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 5 skipped benchmarks1

Comparing finalize-transfer-decoder-before-callback (79fb73a) with main (212819d)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 11, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Re-trigger cubic

@Kludex
Kludex merged commit 51ff1a4 into main Oct 11, 2026
14 checks passed
@Kludex
Kludex deleted the finalize-transfer-decoder-before-callback branch October 11, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kludex